[core] Fix theming bugs #3809
Merged
[core] Fix theming bugs #3809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm pretty sure the console error mentioned above is because the playgrounds aren't using v6 of Material UI, so it should eventually be solved once mui/material-ui#43001 is solved. |
Janpot
approved these changes
Jul 22, 2024
|
@Janpot just adding a few more small changes in a few minutes (added now, just some more props so I assume it should be good to merge) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to fix remaining theming bugs:
defaultModeis not set todark(even though there seems to be no flash with wrong theme, I don't think this happened before MUI v6 either)