Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DashboardLayout] Add navigation actions #3776

Merged
merged 16 commits into from
Jul 24, 2024
Merged

[DashboardLayout] Add navigation actions #3776

merged 16 commits into from
Jul 24, 2024

Conversation

apedroferreira
Copy link
Member

@apedroferreira apedroferreira commented Jul 12, 2024 •
edited
Loading

Make it possible to render any content as an action in navigation items, such as badges or popover menus.

Also includes a few small unrelated general improvements to the documentation such as better example theme colors and initial page in the demos.

Closes #3608

Documentation: https://deploy-preview-3776--mui-toolpad-docs.netlify.app/toolpad/core/react-dashboard-layout/#navigation

Includes:

  • Feature
  • Documentation
  • Test

@apedroferreira apedroferreira added the feature: Components Button, input, table, etc. label Jul 12, 2024
@apedroferreira apedroferreira self-assigned this Jul 12, 2024
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 19, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 22, 2024
@apedroferreira apedroferreira changed the title [DashboardLayout] Add navigation badges [DashboardLayout] Add navigation actions Jul 22, 2024
@apedroferreira apedroferreira marked this pull request as ready for review July 22, 2024 16:36
@apedroferreira apedroferreira requested a review from a team July 22, 2024 16:36
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 23, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 23, 2024
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 23, 2024
@Janpot
Copy link
Member

Janpot commented Jul 24, 2024

Follow-up PR:
The scrollbars in those preview windows are not a great UX, when I try to scroll past them, the code view takes over. We should avoid doing this. The easiest way will be to scope down the demos. Instead of creating 1 demo that shows badges + menus + buttons. Show a demo for each of them, with a non-scrolling preview. Essentially the same can be done for the first demo, instead of creating a showcase that displays all functionalities, create a subsection for each of them: page, folder, subheader, divider.

Janpot
Janpot approved these changes Jul 24, 2024
View reviewed changes
Copy link
Member

@Janpot Janpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. We can improve the docs page in follow up.

@apedroferreira apedroferreira mentioned this pull request Jul 24, 2024
Closed
@apedroferreira
Copy link
Member Author

Approving. We can improve the docs page in follow up.

Got it, made an issue for improvements in #3836

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 24, 2024
@apedroferreira apedroferreira enabled auto-merge (squash) July 24, 2024 14:00
@apedroferreira apedroferreira merged commit 680d34f into mui:master Jul 24, 2024
13 checks passed
@apedroferreira apedroferreira deleted the navigation-badges branch July 24, 2024 14:23
@oliviertassinari oliviertassinari added the component: layout This is the name of the generic UI component, not the React module! label Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Janpot Janpot Janpot approved these changes

Assignees

@apedroferreira apedroferreira

Labels
component: layout This is the name of the generic UI component, not the React module! feature: Components Button, input, table, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DashboardLayout] Add badges to navigation entries
3 participants
@apedroferreira @Janpot @oliviertassinari