-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pickers] Move the field opening logic inside the field components #15671
Draft
flaviendelangle
wants to merge
26
commits into
mui:master
Choose a base branch
from
flaviendelangle:opening-field
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,462
−1,106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaviendelangle
added
breaking change
component: pickers
This is the name of the generic UI component, not the React module!
labels
Nov 29, 2024
Localization writing tips ✍️Seems you are updating localization 🌍 files. Thank you for contributing to the localization! 🎉 To make your PR perfect, here is a list of elements to check: ✔️
Deploy preview: https://deploy-preview-15671--material-ui-x.netlify.app/ Updated pages: |
flaviendelangle
force-pushed
the
opening-field
branch
from
November 29, 2024 13:01
d12b422
to
9a2d4d8
Compare
flaviendelangle
force-pushed
the
opening-field
branch
from
November 29, 2024 13:01
9a2d4d8
to
d94e368
Compare
66 tasks
flaviendelangle
force-pushed
the
opening-field
branch
from
December 2, 2024 09:33
d648755
to
7086ea1
Compare
flaviendelangle
force-pushed
the
opening-field
branch
from
December 2, 2024 09:46
7086ea1
to
5e0edb3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking change
component: pickers
This is the name of the generic UI component, not the React module!
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11035
Closes #7869
Closes #14787
That one will be hard to split 😬
useClearableField
hook is no longer used internally. It can remain available for custom fields during v8, in v9 we will have the composition API for a better DXopenPickerButtonPosition
andclearButtonPosition
field props.Not in this PR:
useEnrichedRangePickerFieldProps
stills handle the opening on click