Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pickers] Move the field opening logic inside the field components #15671

Draft
wants to merge 26 commits into
base: master
Choose a base branch
from

Conversation

flaviendelangle
Copy link
Member

@flaviendelangle flaviendelangle commented Nov 29, 2024

Closes #11035
Closes #7869
Closes #14787

That one will be hard to split 😬

  • The non-range mobile pickers now open using a button (instead of click)
  • The non-range mobile pickers have now an editable field
  • The opening logique of the non-range pickers is now handled by the field themselves
  • The useClearableField hook is no longer used internally. It can remain available for custom fields during v8, in v9 we will have the composition API for a better DX
  • The clear button and the opening button can now independently be rendered on the start of on the end of the field using the openPickerButtonPosition and clearButtonPosition field props.

Not in this PR:

  • The single input range fields are using the new component that handles the adornments, but the opening button is always hidden (because the useEnrichedRangePickerFieldProps stills handle the opening on click
  • The multi input range fields are not yet using the new component that handles the adornments

@flaviendelangle flaviendelangle self-assigned this Nov 29, 2024
@flaviendelangle flaviendelangle added breaking change component: pickers This is the name of the generic UI component, not the React module! labels Nov 29, 2024
@mui-bot
Copy link

mui-bot commented Nov 29, 2024

Localization writing tips ✍️

Seems you are updating localization 🌍 files.

Thank you for contributing to the localization! 🎉 To make your PR perfect, here is a list of elements to check: ✔️

  • Verify if the PR title respects the release format. Here are two examples (depending if you update or add a locale file)

    [l10n] Improve Swedish (sv-SE) locale
    [l10n] Add Danish (da-DK) locale

  • Update the documentation of supported locales by running pnpm l10n
  • Clean files with pnpm prettier.

Deploy preview: https://deploy-preview-15671--material-ui-x.netlify.app/

Updated pages:

Generated by 🚫 dangerJS against 5e0edb3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change component: pickers This is the name of the generic UI component, not the React module!
Projects
None yet
2 participants