CodSpeed Performance Report

Merging #15630 will not alter performance

_{Comparing alexfauquette:update-tooltip-design (8c23d0a) with master (c185e2f)}

Summary

✅ 6 untouched benchmarks

Deploy preview: https://deploy-preview-15630--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 8c23d0a

Different "color indicator" shapes for different graphs

Yes, I keep that one is a bit more technical so I prefer to keep it in a distinct PR. Notice it will also impact the legend.

I feel like the first picture should me more similar to this.

I agree mine feels a bit weird. Maybe a min-width could solve that

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Looks like a nice first step towards the redesign 🎉 🚀

I'm fine with doing the different "color indicator" shapes for different graphs in a follow-up 👌

I agree mine feels a bit weird. Maybe a min-width could solve that

Yes, I would definitely add a min width to the tooltip. The new design should work well both with 'smaller' labels and longer ones. Spacing it out with a min-width could solve this 🙈
A few additional notes:

• What font-sizes do we use for the labels? They feel a bit bloated to me 🤔
• Are we using Roboto for the charts? The font-family looks off to me... Not sure if the plan for charts is to go towards a more material-ish default, but maybe we should use the same font-family as in the other component libraries
  

• using Roboto

Yeah they use the same style, but one is rendered in SVG and the other in HTML, so there are some differences there 🙃

Should be handled in #15733

I intend to do a pass on tooltips after legends are done. So we can use the correct mark shapes.