-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add web-ext submit
to submit listed add-ons to AMO
#804
Comments
The |
Automate all the things! 😉 Here people discussed the Chrome Web Store version, but it also applies to AMO sindresorhus/project-ideas#66 |
Yeah, using web-ext to automatically put a new version in the AMO review queue seems like it could be useful to support automatic deployment (from a git tag or whatever). I think it would make sense as a new command, such as what you recommended: The good news is that sign-addon already wraps up the signing API pretty well. The bad news is that the API doesn't support submission of listed add-ons in a straightforward way. Using the signing API to submit a listed add-on would be a hack and I'm not sure that it would be so dependable against future API changes. The fact that it works now at all is just by side effect. We decided to log an informative message about it in |
100% this! I just setup some tasks to automate submitting my extension to the Chrome web store and now I'm working on Firefox (first time ever messing with Firefox Add-ons, so happy about WebExtensions). Looking through the Firefox documentation it wasn't clear to me at all that I could automate sending updates to AMO for an existing add-on... not for self-hosting/self-signing. I even just asked a question on stackoverflow about this. |
Even if we added a |
Understood. The current It's still better than packaging it up, opening the browser, visiting AMO, uploading it, etc manually. |
agreed . I just want Travis to be able to build and send it off my extension to each respective store. I understand that there's a review process. I guess for now I'll deal with the error. @bfred-it are you requiring |
@FranciscoG I'm not, I plan on using it via |
WorkaroundI published a 11-lines, temporary npm install --global web-ext-submit
web-ext-submit Meant to be used on Travis or GitHub Actions. https://github.com/fregante/web-ext-submit Alternative |
Hello, Thank you @bfred-it |
|
@bfred-it you can add sources to your webextension, to help review |
Ah I see what you mean, you have a gulp build step in place. I left a link to the repo in the notes for the reviewer before to show the source. |
@guillaumevincent this command uses the Signing API, which only allows the upload of the extension itself. I don't see |
web-ext submit
to only submit for reviewweb-ext submit
to submit listed add-ons to AMO
I removed the "submit for review" part of this issue title because post-review has landed! In other words, listed add-ons are now published ASAP without needing to pass human review. This makes something like a |
Any updates to ETA on blockers for mozilla/addons-server#804 / the mozilla/addons-server#804 itself? |
Any help with this? I'm removing our addon from Firefox store because it's unmanageable doing manually every time 😞 |
The things we're still missing are blocked on API support:
Both |
You can use https://github.com/fregante/web-ext-submit |
@fregante we agree that source upload is not working yet right? |
That isn't possible at all, refer to mozilla/sign-addon#409 and mozilla/addons#6158 |
Workaround for mozilla/web-ext#804
This was completed with #2503 (and linked issues). |
#2497 will add this within |
This comment was marked as resolved.
This comment was marked as resolved.
It's in the current version, but there are still a few outstanding pieces of work to "finish" it, such as mozilla/addons-server#2497 |
I finally got the chance to use use this API, it works! - web-ext-submit
+ web-ext sign --use-submission-api --channel listed |
Workaround described below ⬇️
Is this a bug or feature request?
Feature request
What is the current behavior?
web-ext sign
already successfully submits an extension for review, but then it throws an error.What is the expected or desired behavior?
I don't need instant signing, so if the submission has been successful there should be a way to make it exit with 0.
Suggestions:
Version information (for bug reports)
OS X 10.11.6
v7.2.0
3.10.9
1.8.1
The text was updated successfully, but these errors were encountered: