Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some code in all entrypoints to support docker secrets (https://docs.docker.com/engine/swarm/secrets/) as requested here: monicahq/monica#5809
Instead of supporting secrets (chosen naming convention is
<environment variable name>
+_FILE
suffix, e.g.DB_PASSWORD_FILE
- some containers use__FILE
) for all environment variables, a set of supported secrets is defined insupportedSecrets
. Then it is checked whether the environment variable with the suffix exists and whether the secrets file exists.If all checks pass, the original environment variable is overwritten with the contents contained in the secrets file.
It can be tested with the following example
docker-compose.yml
:I haven't updated the
docker-compose.yml
examples as I first want to check the waters.