feat(api): Moving contribution calculation out of models #1726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now monetr calculates contributions to expenses and goals using some specific code co-located in the models package. This isn't great as that package should not contain business logic as much as possible. This is the groundwork of moving that logic out of that package and to make use of the existing forecasting code to facilitate the same calculations. This should also make things more consistent as both the contribution and spending calculations will be the same code.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1726 +/- ##
==========================================
- Coverage 52.47% 52.29% -0.19%
==========================================
Files 365 366 +1
Lines 20509 20630 +121
Branches 500 500
==========================================
+ Hits 10763 10788 +25
- Misses 9129 9222 +93
- Partials 617 620 +3 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now monetr calculates contributions to expenses and goals using
some specific code co-located in the models package. This isn't great as
that package should not contain business logic as much as possible. This
is the groundwork of moving that logic out of that package and to make
use of the existing forecasting code to facilitate the same
calculations. This should also make things more consistent as both the
contribution and spending calculations will be the same code.