Skip to content

Conversation

@ccreighton-apptio
Copy link
Contributor

@ccreighton-apptio ccreighton-apptio commented Nov 5, 2025

Fixes a type change.

Motivation and Context

In #1692 I inadvertently changed the type of tool arguments from unknown to string

How Has This Been Tested?

Defined a sample CallToolRequest to ensure that any arguments are allowed:

const callToolRequest: CallToolRequest = {
  id: 'foo',
  jsonrpc: "2.0",
  method: "tools/call",
  params: {
    name: "foo",
    _meta: {
      any: 'no typescript error here',
      thing: {
        complex: 'object'
      }
    },
    arguments: {
      any: 1,
      thing: "here",
      at: {
        all: "not just strings"
      }
    },
    badKey: 'typescript error here - invalid key',
  }
}

Breaking Changes

No, it fixes an inadvertent breaking change.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

Copy link
Member

@jonathanhefner jonathanhefner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dsp-ant This is a fast-follow to #1692.

@pcarleton pcarleton merged commit bcdd336 into modelcontextprotocol:main Nov 7, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants