-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add hideKeyboard event #165
Merged
dmitry-zaitsev
merged 8 commits into
mobile-dev-inc:main
from
depapp:feature/hideKeyboard
Sep 12, 2022
Merged
feat: add hideKeyboard event #165
dmitry-zaitsev
merged 8 commits into
mobile-dev-inc:main
from
depapp:feature/hideKeyboard
Sep 12, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitry-zaitsev
suggested changes
Sep 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but please also add:
- iOS support as mentioned in a comment
- Integration test
I've updated the PR. could you please help to review it again? 🙇🏻 |
dmitry-zaitsev
approved these changes
Sep 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thank you
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hi @dmitry-zaitsev
description
I have an issue when try to
tapOn
a button that blocked by device keyboard.the UI before keyboard is showing
the UI after keyboard is showing
solution
I've tried to add
hideKeyboard()
event to avoid that failed case (beforetapOn()
desired button)