document testing of complexity vs. efficiency for reversing output

mikebd · Oct 9, 2023 · 9ab2887 · 9ab2887
1 parent 0b6753d
commit 9ab2887
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/controller/rest/v1/logs.go b/controller/rest/v1/logs.go
@@ -43,6 +43,10 @@ func GetLog(w http.ResponseWriter, r *http.Request, p httprouter.Params) {
 
 	logEvents, err := service.GetLog(config.LogDirectory, logFilename, maxLines)
 
+	// Reverse the slice - we want the most recent events first.
+	// Tests to see if this is slower than just iterating backwards when rendering
+	// showed that it was not.  This is easier to read for maintainability.
 	slices.Reverse(logEvents)
+
 	util.RenderTextPlain(w, logEvents, err)
 }