Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix styling to improve heading spacing fixes #102036 #102427

Merged
merged 3 commits into from
Jul 14, 2020
Merged

fix styling to improve heading spacing fixes #102036 #102427

merged 3 commits into from
Jul 14, 2020

Conversation

jasonwilliams
Copy link
Contributor

@jasonwilliams jasonwilliams commented Jul 13, 2020 •
edited
Loading

This PR fixes #102036

  • So the first issue is that most elements have a margin-top and margin-bottom.
    It made sense to remove the margin-top and let top elements push others down. (otherwise you fall into margin-collapse hell)
  • This means the body needs a padding on the top so that any first element has a gap (and not just the H1)
  • Headings have a smaller bottom margin so as to look more like a section
  • If 2 paragraphs are next to each other, the second paragraph reduces its top margin to bring them closer together.

Before

image

After

image

pings @mjbvz

@ghost
Copy link

ghost commented Jul 13, 2020 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@jasonwilliams jasonwilliams changed the title updating styling to make headings look better fixes #102036 updating styling to improve heading spacing fixes #102036 Jul 13, 2020
@jasonwilliams jasonwilliams changed the title updating styling to improve heading spacing fixes #102036 fix styling to improve heading spacing fixes #102036 Jul 13, 2020
@mjbvz mjbvz added this to the July 2020 milestone Jul 14, 2020
@mjbvz mjbvz merged commit b8e773e into microsoft:master Jul 14, 2020
@mjbvz
Copy link
Collaborator

mjbvz commented Jul 14, 2020

Looks good!

Merged for the 1.48 insiders builds so we can make sure these changes work well out on real world markdown

Charles-Gagnon pushed a commit to Charles-Gagnon/vscode that referenced this pull request Jul 14, 2020
@jasonwilliams @Charles-Gagnon
fix styling to improve heading spacing fixes microsoft#102036 (micros…
fd87d77 
…oft#102427)

* updating styling to make headings look better

* be consistent and use em
@github-actions github-actions bot locked and limited conversation to collaborators Aug 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@mjbvz mjbvz

Labels
None yet
Projects
None yet
Milestone
July 2020
Development

Successfully merging this pull request may close these issues.

Improve heading spacing on Markdown preview
2 participants
@jasonwilliams @mjbvz