Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only throw error if releaseNotesUrl doesn't exist #102149

Merged
merged 2 commits into from
Jul 21, 2020
Merged

Only throw error if releaseNotesUrl doesn't exist #102149

merged 2 commits into from
Jul 21, 2020

Conversation

Charles-Gagnon
Copy link
Contributor

No description provided.

@Charles-Gagnon Charles-Gagnon mentioned this pull request Jul 10, 2020
Merged
@weinand weinand removed their assignment Jul 10, 2020
@NotWearingPants
Copy link
Contributor

NotWearingPants commented Jul 17, 2020 •
edited
Loading

Haha oops, I guess @mjbvz and I didn't test #101158 that well, sorry.

I missed that possibility because releaseNotesUrl wasn't configured in my build, so I only tested it either successfully opened the release notes view inside the editor, or showed an error that it failed to fetch them and that this version doesn't have a release notes URL.

The await inside that if used to be a return, so this is a new bug.

@joaomoreno joaomoreno added this to the July 2020 milestone Jul 21, 2020
@joaomoreno
Copy link
Member

Thanks!

@joaomoreno joaomoreno merged commit 5c7e862 into microsoft:master Jul 21, 2020
@joaomoreno joaomoreno added the install-update VS Code installation and upgrade system issues label Jul 21, 2020
@Charles-Gagnon Charles-Gagnon deleted the patch-1 branch July 21, 2020 14:50
@github-actions github-actions bot locked and limited conversation to collaborators Sep 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@NotWearingPants NotWearingPants NotWearingPants approved these changes

Assignees

@joaomoreno joaomoreno

Labels
install-update VS Code installation and upgrade system issues
Projects
None yet
Milestone
July 2020
Development

Successfully merging this pull request may close these issues.
4 participants
@Charles-Gagnon @NotWearingPants @joaomoreno @weinand