fix #100437 Improve 'terminal.integrated.commandsToSkipShell' info #100445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…' information in Settings Editor
|
@roblourens how about this? |
|
I was thinking more pushing the [...] up and making it a link to expand the section fully. |
@Tyriar fine by me, but maybe consider taking some/all of the revisions I've made to the preamble text in this PR? |
|
Yeah I would rather not tell the user to click these links, but I'll leave it to @Tyriar whether he wants the text changes |
Me too. If we could specify a |
Tyriar
requested changes
Jul 8, 2020
src/vs/workbench/contrib/terminal/common/terminalConfiguration.ts
Outdated
Show resolved
Hide resolved
Tyriar
approved these changes
Jul 9, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve 'terminal.integrated.commandsToSkipShell' information in Settings Editor
This PR fixes #100437
New display is:
Note the use of two command links to help user view the full list of defaults.
Previously it was:
