Skip to content

Add a timeout for getting suggestions from the LMProvider #18234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
PankajBhojwani wants to merge 7 commits into
base: feature/llm
Choose a base branch
from
Open

Add a timeout for getting suggestions from the LMProvider #18234

PankajBhojwani wants to merge 7 commits into from

Conversation

@PankajBhojwani
Copy link
Contributor

@PankajBhojwani PankajBhojwani commented Nov 22, 2024 •
edited
Loading

Summary of the Pull Request

  • Each LM provider implements a timeout now for operations that may take too long (the http request for all 3 of them, and additionally the reauthentication request for Github Copilot)
  • The Extension Palette implements a longer timeout in case any LM provider misbehaves

Validation Steps Performed

User receives an error message if operations take too long

PR Checklist

  • Closes #xxx
  • Tests added/passed
  • Documentation updated
    • If checked, please file a pull request on our docs repo and link it here: #xxx
  • Schema updated (if necessary)

DHowett
DHowett reviewed Nov 22, 2024
View reviewed changes
DHowett
DHowett requested changes Nov 22, 2024
View reviewed changes
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Nov 22, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Nov 22, 2024
lhecker
lhecker reviewed Nov 23, 2024
View reviewed changes
@PankajBhojwani PankajBhojwani marked this pull request as draft November 26, 2024 00:25
@PankajBhojwani
Copy link
Contributor Author

PankajBhojwani commented Nov 26, 2024

Converting to draft for now as I figure out a solution for the extra time needed for reauthentication

@PankajBhojwani PankajBhojwani marked this pull request as ready for review November 27, 2024 00:17
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 27, 2024
View reviewed changes
@github-actions

This comment has been minimized.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lhecker lhecker lhecker approved these changes

@DHowett DHowett DHowett requested changes

@carlos-zamora carlos-zamora carlos-zamora approved these changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@PankajBhojwani @DHowett @lhecker @carlos-zamora