Skip to content

Changed new tab index on tab close to next tab #18022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DHowett merged 2 commits into from
Oct 11, 2024
Merged

Changed new tab index on tab close to next tab #18022

DHowett merged 2 commits into from
Oct 11, 2024

Conversation

@michaeljsXu
Copy link
Contributor

@michaeljsXu michaeljsXu commented Oct 10, 2024

Summary of the Pull Request

Changed newSelectedIndex on tab close to tabIndex instead of tabIndex - 1.

References and Relevant Issues

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

tab_close_focus_right

PR Checklist

@microsoft-github-policy-service microsoft-github-policy-service bot added Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. labels Oct 10, 2024
@michaeljsXu michaeljsXu marked this pull request as draft October 10, 2024 04:54
@michaeljsXu michaeljsXu marked this pull request as ready for review October 10, 2024 04:56
lhecker
lhecker approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@lhecker lhecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

DHowett
DHowett requested changes Oct 10, 2024
View reviewed changes
Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You know what, I'm a-ok with this. Thank you.

Would you be able to update the Reasoning in the block comment above your change to newSelectedIndex?

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Oct 10, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Oct 10, 2024
@DHowett
Copy link
Member

DHowett commented Oct 10, 2024

Thanks so much!

@DHowett DHowett enabled auto-merge (squash) October 10, 2024 23:38
@DHowett DHowett merged commit d0e9436 into microsoft:main Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DHowett DHowett DHowett approved these changes

@lhecker lhecker lhecker approved these changes

Assignees

No one assigned

Labels

Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Product-Terminal The new Windows Terminal.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Focus should move to next tab when closing a tab

3 participants

@michaeljsXu @DHowett @lhecker