OpenConsole.psm1 PSVersion check #18021
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
Issue-Task
lhecker
reviewed
Oct 10, 2024
tools/OpenConsole.psm1
Outdated
Comment on lines
1
to
5
| # throw error if Powershell version is lower than 7 | ||
| if ($PSVersionTable.PSVersion.Major -lt 7) { | ||
| throw "This script requires PowerShell 7 or higher. Current version: $($PSVersionTable.PSVersion)" | ||
| exit | ||
| } |
There was a problem hiding this comment.
Why not use #Requires -Version 7? https://learn.microsoft.com/en-us/powershell/module/microsoft.powershell.core/about/about_requires
There was a problem hiding this comment.
Thank you, I changed it to using #Requires.
DHowett
requested changes
Oct 10, 2024
microsoft-github-policy-service
bot
added
the
Needs-Author-Feedback
|
Zadjii-msft's original assessment may have been wrong here |
|
Just to double check, is the Powershell 7 requirement in prerequisites for a different part of the project? I thought maybe something would require it along the way in OpenConsole |
microsoft-github-policy-service
bot
added
Needs-Attention
DHowett
approved these changes
Oct 11, 2024
DHowett
added a commit
that referenced
this pull request
Oct 15, 2024
We started requiring PowerShell 7+ in #18021 We did not update the code formatting task.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Added a check in OpenConsole.psm1 to throw an error if the Powershell version is <7.
References and Relevant Issues
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed
Confirmed that attempting to
Import-Module .\tools\OpenConsole.psm1throws an error on Powershell 5.PR Checklist
OpenConsole.psm1module should display an error message when used on Windows PowerShell 5 #17505