Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update page-object-model example #16661

Merged
merged 1 commit into from
Aug 20, 2022
Merged

docs: update page-object-model example #16661

merged 1 commit into from
Aug 20, 2022

Conversation

depapp
Copy link
Contributor

@depapp depapp commented Aug 19, 2022

hi all,
there's failed test example in https://playwright.dev/docs/test-pom related to wrong selector and text assertion.

after this PR:
after

before this PR:
before

@ghost
Copy link

ghost commented Aug 19, 2022 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@pavelfeldman
Copy link
Member

Thanks!

@pavelfeldman pavelfeldman merged commit 1730f33 into microsoft:main Aug 20, 2022
@depapp depapp deleted the update_pom_docs branch August 20, 2022 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavelfeldman pavelfeldman pavelfeldman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@depapp @pavelfeldman