feat(aws): add s3 support to input, storage, output, cache, etc. #1830
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knguyen1
changed the title
Author
|
@microsoft-github-policy-service agree |
…repend remote uri
* Fix fnllm version * Semver
|
Can you add the option to enter the endpoint URL to the boto3 client as well so that storage to other platforms such as minIO is also possible through the S3 API? |
Author
Done: f1fd55d |
Author
|
Please review @natoverse |
knguyen1
force-pushed
the
feat/add-s3-support
branch
from
30380b4 to
4dcc89d
Compare
knguyen1
force-pushed
the
feat/add-s3-support
branch
from
6272869 to
4040d4b
Compare
Author
|
@natoverse @AlonsoGuevara review please? |
|
What is the status of this PR? We run out infra on AWS, so would be cool to have this functionality |
Author
|
Unless you review this PR soon, I'm going to close without merging. I am now getting conflicts too numerous and too complex to resolve cleanly. @natoverse @AlonsoGuevara |
- Resolved conflicts in graphrag/config/defaults.py by accepting upstream changes and removing S3-specific fields from OutputDefaults and UpdateIndexOutputDefaults - Resolved conflicts in graphrag/config/enums.py by renaming OutputType to StorageType and removing InputType as per upstream changes - Resolved conflicts in graphrag/index/input/factory.py by accepting upstream simplification that uses passed storage parameter - Removed graphrag/config/models/output_config.py as it was deleted upstream and replaced with generic StorageConfig - Updated graphrag/config/models/graph_rag_config.py to use new enum names and fix S3 validation logic to work with new config structure - Fixed graphrag/storage/factory.py to use StorageType instead of OutputType - Added proper type annotations to dataclass fields in defaults.py to fix linting errors - Maintained S3 support in InputConfig, CacheConfig, and ReportingConfig where it's still available
Author
|
Closing due to inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds s3 integration to GraphRAG; support both AWS s3 and s3-like services (via
endpoint_url; minio, etc.).Related Issues
#1306
Proposed Changes
graphrag/storage/s3_pipeline_storage.py)graphrag/callbacks/s3_workflow_callbacks.py)graphrag/config/prompt_getter.py)docs/config/s3.md)Checklist
Additional Notes