Skip to content

fix(60563):@import * as namespace cannot be used with @implements #60566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jakebailey merged 3 commits into from
Jan 17, 2025
Merged

fix(60563):@import * as namespace cannot be used with @implements #60566

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6586021
fix(60563): treat JSDoc implements tag as identifier in non-emitting …
a-tarasyuk Nov 23, 2024
82e76ec
consider type only alias as valid for jsdoc context
a-tarasyuk Jan 17, 2025
cb0714c
Merge branch 'main' of https://github.com/microsoft/TypeScript into f…
a-tarasyuk Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
consider type only alias as valid for jsdoc context
  • Loading branch information
@a-tarasyuk
a-tarasyuk committed Jan 17, 2025
commit 82e76ec26bac215d7dc19bd3b1097beaf4505b70
5 changes: 2 additions & 3 deletions src/compiler/utilities.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10454,6 +10454,7 @@ export function isValidBigIntString(s: string, roundTripOnly: boolean): boolean
/** @internal */
export function isValidTypeOnlyAliasUseSite(useSite: Node): boolean {
return !!(useSite.flags & NodeFlags.Ambient)
|| isInJSDoc(useSite)
|| isPartOfTypeQuery(useSite)
|| isIdentifierInNonEmittingHeritageClause(useSite)
|| isPartOfPossiblyValidTypeOrAbstractComputedPropertyName(useSite)
Expand Down Expand Up @@ -10483,7 +10484,6 @@ function isIdentifierInNonEmittingHeritageClause(node: Node): boolean {
if (node.kind !== SyntaxKind.Identifier) return false;
const heritageClause = findAncestor(node.parent, parent => {
switch (parent.kind) {
case SyntaxKind.JSDocImplementsTag:
case SyntaxKind.HeritageClause:
return true;
case SyntaxKind.PropertyAccessExpression:
Expand All @@ -10493,8 +10493,7 @@ function isIdentifierInNonEmittingHeritageClause(node: Node): boolean {
return "quit";
}
}) as HeritageClause | undefined;
if (heritageClause === undefined) return false;
return isJSDocImplementsTag(heritageClause) || heritageClause.token === SyntaxKind.ImplementsKeyword || heritageClause.parent.kind === SyntaxKind.InterfaceDeclaration;
return heritageClause?.token === SyntaxKind.ImplementsKeyword || heritageClause?.parent.kind === SyntaxKind.InterfaceDeclaration;
}

/** @internal */
Expand Down
Loading