Skip to content

Avoid calling replace in normalizeSlashes when it would do nothing #44100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amcasey merged 2 commits into from
May 21, 2021
Merged

Avoid calling replace in normalizeSlashes when it would do nothing #44100

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c797a5
Make normalizeSlashes a no-op there are no bad slashes
amcasey May 14, 2021
aaaf09f
Reuse already-computed index
amcasey May 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Make normalizeSlashes a no-op there are no bad slashes 
On Windows, there will probably be a negligible slowdown, iterating over
the pre-slash prefix of each unnormalized path (though we might come out
ahead if paths are normalized more than once).

On *nix, this saves work - 1.8s -> 0.4s in the project I'm
investigating.
  • Loading branch information
@amcasey
amcasey committed May 14, 2021
commit 0c797a55dab2ce3539fe8602e217fc22a8d3f624
4 changes: 3 additions & 1 deletion src/compiler/path.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,7 +452,9 @@ namespace ts {
* Normalize path separators, converting `\` into `/`.
*/
export function normalizeSlashes(path: string): string {
return path.replace(backslashRegExp, directorySeparator);
return path.indexOf(altDirectorySeparator) === -1
? path
: path.replace(backslashRegExp, directorySeparator);
}

/**
Expand Down