Skip to content

Added configurable way to dump Picard logs into a file #2146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zas merged 5 commits into from
Sep 8, 2022
Merged

Added configurable way to dump Picard logs into a file #2146

zas merged 5 commits into from
Sep 8, 2022

Conversation

@skelly37
Copy link
Contributor

@skelly37 skelly37 commented Sep 7, 2022 •
edited
Loading

Summary

  • This is a…
    • Bug fix
    • Feature addition
    • Refactoring
    • Minor / simple change (like a typo)
    • Other
  • Describe this change in 1-2 sentences:

Problem

A commands to write logs into a file

  • JIRA ticket (optional): None

Solution

Added WRITE_LOGS

Action

@zas @phw please take a look if you like the approach :)

@skelly37
Copy link
Contributor Author

skelly37 commented Sep 7, 2022

1 minor issue, LOG_CLEAR does not seem to affect the command and basically the whole log history gets dumped :(

zas
zas requested changes Sep 7, 2022
View reviewed changes
@skelly37 skelly37 requested a review from zas September 7, 2022 20:16
zas
zas requested changes Sep 8, 2022
View reviewed changes
@zas zas requested a review from phw September 8, 2022 06:21
@skelly37 skelly37 requested review from zas and removed request for phw September 8, 2022 06:41
zas
zas approved these changes Sep 8, 2022
View reviewed changes
Copy link
Collaborator

@zas zas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zas zas merged commit 4a43dec into metabrainz:master Sep 8, 2022
@skelly37 skelly37 deleted the WRITE_LOGS branch September 8, 2022 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zas zas zas approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@skelly37 @zas