Skip to content

Conversation

@skelly37
Copy link
Contributor

@skelly37 skelly37 commented Sep 6, 2022

Summary

  • This is a…
    • Bug fix
    • Feature addition
    • Refactoring
    • Minor / simple change (like a typo)
    • Other
  • Describe this change in 1-2 sentences:

Problem

A command allowing to clear Picard logs.

  • JIRA ticket (optional): None

Solution

TBD

Action

@skelly37
Copy link
Contributor Author

skelly37 commented Sep 6, 2022

It works fine except for one edge case:

the log window is opened while receiving LOG_CLEAR — if you do something like this, no further LOG_CLEAR will work properly

- it clears both logs, the error/debug one and the history one
@rdswift
Copy link
Collaborator

rdswift commented Sep 7, 2022

Will we also be introducing a WRITE_LOG command to dump the log to a file, or is it already in the works and I missed it?

@skelly37
Copy link
Contributor Author

skelly37 commented Sep 7, 2022

Will we also be introducing a WRITE_LOG command to dump the log to a file, or is it already in the works and I missed it?

It's on a TODO list, see my PR on docs

@skelly37 skelly37 marked this pull request as ready for review September 7, 2022 14:37
@skelly37 skelly37 requested a review from zas September 7, 2022 14:37
@skelly37 skelly37 changed the title LOG_CLEAR command CLEAR_LOGS Sep 7, 2022
@skelly37 skelly37 changed the title CLEAR_LOGS CLEAR_LOGS command Sep 7, 2022
@rdswift
Copy link
Collaborator

rdswift commented Sep 7, 2022

Should it be rather pop or read? Both approaches make sense to me, so I'd like to see how do you see it as a requester.

I think read makes more sense to me.

@zas zas merged commit 5ed7de2 into metabrainz:master Sep 7, 2022
@skelly37 skelly37 deleted the logs branch September 8, 2022 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants