Skip to content

Added command: LOAD #2142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
phw merged 3 commits into from
Sep 7, 2022
Merged

Added command: LOAD #2142

phw merged 3 commits into from
Sep 7, 2022

Conversation

@skelly37
Copy link
Contributor

@skelly37 skelly37 commented Sep 4, 2022 •
edited
Loading

Summary

  • This is a…
    • Bug fix
    • Feature addition
    • Refactoring
    • Minor / simple change (like a typo)
    • Other
  • Describe this change in 1-2 sentences:
    A command that allows to load files as a part of the command pipeline

Problem

It would be useful to load a file after some commands have already been executed as a part of the pipeline. The load command extends positional arguments' functionality.

  • JIRA ticket (optional): None

Solution

Added the needed command

Action

Should be squashed on merge

@rdswift
Copy link
Collaborator

rdswift commented Sep 4, 2022 •
edited
Loading

Could this be used to load URLs and MBIDs as well? If so you might be better off passing the argument list to load_to_Picard() for processing rather than adding the arguments directly using add_paths().

@skelly37
Copy link
Contributor Author

skelly37 commented Sep 4, 2022

Could this be used to load URLs and MBIDs as well? If so you might be better off passing the argument list to load_to_Picard() for processing rather than adding the arguments directly using add_paths().

Could be, I wasn't sure if it should be added. What's your take on this @zas @phw ?

@rdswift
Copy link
Collaborator

rdswift commented Sep 5, 2022

Could be, I wasn't sure if it should be added. What's your take on this @zas @phw ?

My thinking was that it should operate the same as files, etc. entered on the command line, as described by @zas in his comment on #2137.

So you're saying that we should ditch the positional argument FILE_OR_URL in favor of adding a LOAD command which would be the only way to load something to picard?

Nope, in addition. Basically picard would be equivalent to picard -e LOAD . The idea is to let user use only -e commands to achieve the same thing.

@skelly37
Copy link
Contributor Author

skelly37 commented Sep 5, 2022

Ping @phw @zas , fully done imo

zas
zas requested changes Sep 5, 2022
View reviewed changes
@skelly37 skelly37 requested a review from zas September 5, 2022 20:26
zas
zas approved these changes Sep 5, 2022
View reviewed changes
Copy link
Collaborator

@zas zas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zas zas requested review from phw and rdswift September 5, 2022 20:31
rdswift
rdswift approved these changes Sep 5, 2022
View reviewed changes
Copy link
Collaborator

@rdswift rdswift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.

@phw phw merged commit fc48ee5 into metabrainz:master Sep 7, 2022
@skelly37 skelly37 deleted the load-command branch September 7, 2022 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@phw phw phw approved these changes

@zas zas zas approved these changes

@rdswift rdswift rdswift approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@skelly37 @rdswift @phw @zas