unparsed_args removed from tagger.py#2127
Merged
phw merged 2 commits intometabrainz:masterfrom Jul 4, 2022
Merged
Conversation
Since the variable wasn't used anywhere (wasn't even stored as `Tagger`'s attribute), I'd suggest to remove it, unless you have some reason to still keep it there.
Contributor
Author
|
The issue has already been discussed in my GSoC PR and since the single-instance-mode is getting final polishing, there's more time for smaller and greater refactoring :) |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
zas
approved these changes
Jul 1, 2022
phw
approved these changes
Jul 4, 2022
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Since the variable wasn't used anywhere (wasn't even stored as
Tagger's attribute), I'd suggest to remove it, unless you have some reason to still keep it there.Problem
Unused variable returned, stored and passed to the
Tagger's constructor just to be left untouchedSolution
I've safely removed all the
unparsed_args's ocurrences.