Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix wrong volumes mount name for "host-var-run" #261

Merged
merged 1 commit into from
Feb 6, 2023
Merged

fix wrong volumes mount name for "host-var-run" #261

merged 1 commit into from
Feb 6, 2023

Conversation

yanggangtony
Copy link
Contributor

@yanggangtony yanggangtony commented Jan 18, 2023 •
edited
Loading

Signed-off-by: yanggang [email protected]

Fix mount volumes path , keep the same with others..

    volumes:
      - hostPath:
          path: /var/run
        name: host-var-run
      - hostPath:
          path: /tmp
        name: tmp-dir

@yanggangtony yanggangtony requested a review from a team as a code owner January 18, 2023 11:45
@mergify
Copy link

mergify bot commented Jan 18, 2023

Welcome to the Merbridge OpenSource Community!👏

We're delighted to have you onboard 💘

@codecov-commenter
Copy link

Codecov Report

Merging #261 (597c402) into main (1db6259) will not change coverage.
The diff coverage is n/a.

❗ Current head 597c402 differs from pull request most recent head 19f88b8. Consider uploading reports for the commit 19f88b8 to get more accurate results

@@           Coverage Diff           @@
##             main     #261   +/-   ##
=======================================
  Coverage   40.33%   40.33%           
=======================================
  Files           7        7           
  Lines         419      419           
=======================================
  Hits          169      169           
  Misses        236      236           
  Partials       14       14
Flag Coverage Δ
unittests 40.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

kebe7jun
kebe7jun previously approved these changes Jan 19, 2023
View reviewed changes
Copy link
Member

@kebe7jun kebe7jun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@kebe7jun kebe7jun merged commit c91d896 into merbridge:main Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kebe7jun kebe7jun kebe7jun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yanggangtony @codecov-commenter @kebe7jun