Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(frontend): show memory usage in mbs in session timeline #1679

Merged
merged 2 commits into from
Jan 2, 2025
Merged

fix(frontend): show memory usage in mbs in session timeline #1679

merged 2 commits into from
Jan 2, 2025

Conversation

detj
Copy link
Contributor

@detj detj commented Jan 2, 2025

Summary

This PR converts kilobytes to megabytes before showing in memory usage plot in session timeline. Both memory_usage and memory_usage_absolute events are handled.

Tasks

  • Add new kilobytesToMegabytes function
  • Write tests for kilobytesToMegabytes function
  • Convert and format memory_usage events
  • Convert and format memory_usage_absolute events

See also

@detj detj added bug something isn't working frontend frontend related labels Jan 2, 2025
@detj detj self-assigned this Jan 2, 2025
@vercel Vercel
Copy link

vercel bot commented Jan 2, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
measure-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2025 6:09am

@detj detj requested a review from anupcowkur January 2, 2025 06:13
@detj detj merged commit 54cad87 into main Jan 2, 2025
6 checks passed
@detj detj deleted the session-timeline-mb branch January 2, 2025 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anupcowkur anupcowkur anupcowkur approved these changes

Assignees

@detj detj

Labels
bug something isn't working frontend frontend related
Projects
Measure Roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show memory usage in MBs
2 participants
@detj @anupcowkur