Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ja]: remove not() function as it is unnecessary #24781

Merged
merged 3 commits into from
Nov 29, 2024
Merged

[ja]: remove not() function as it is unnecessary #24781

merged 3 commits into from
Nov 29, 2024

Conversation

OHMORIYUSUKE
Copy link
Contributor

@OHMORIYUSUKE OHMORIYUSUKE commented Nov 26, 2024 •
edited
Loading

Description

The translation was incorrect, so I corrected it. The :not() function was unnecessary, so I removed it.

Motivation

I believe incorrect information should be corrected, so I made the necessary fixes.

Additional details

Related issues and pull requests

Fixes #23825
Fixes mozilla-japan/translation#799

@OHMORIYUSUKE OHMORIYUSUKE requested a review from a team as a code owner November 26, 2024 15:21
@OHMORIYUSUKE OHMORIYUSUKE requested review from potappo and removed request for a team November 26, 2024 15:21
@github-actions github-actions bot added the l10n-ja Issues related to Japanese content. label Nov 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 26, 2024 •
edited
Loading

Preview URLs

Flaws (39)

URL: /ja/docs/Learn/JavaScript/Building_blocks/Test_your_skills:_Loops
Title: スキルテスト: ループ
Flaw count: 39

  • macros:
    • /ja/docs/Games/Publishing_games does not exist but fell back to /en-US/docs/Games/Publishing_games
    • /ja/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/React_interactivity_events_state does not exist but fell back to /en-US/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/React_interactivity_events_state
    • /ja/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/React_interactivity_filtering_conditional_rendering does not exist but fell back to /en-US/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/React_interactivity_filtering_conditional_rendering
    • /ja/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/React_accessibility does not exist but fell back to /en-US/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/React_accessibility
    • /ja/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/Ember_getting_started does not exist but fell back to /en-US/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/Ember_getting_started
    • and 34 more flaws omitted

(comment last updated: 2024-11-27 04:57:55)

@OHMORIYUSUKE OHMORIYUSUKE mentioned this pull request Nov 26, 2024
Closed
@OHMORIYUSUKE
Copy link
Contributor Author

@potappo
レビューをお願いします🙇‍♂️

@OHMORIYUSUKE OHMORIYUSUKE mentioned this pull request Nov 29, 2024
Closed
potappo
potappo approved these changes Nov 29, 2024
View reviewed changes
Copy link
Collaborator

@potappo potappo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

修正ありがとうございます。OKです。

@potappo potappo merged commit 8a33fb2 into mdn:main Nov 29, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@potappo potappo potappo approved these changes

Assignees
No one assigned
Labels
l10n-ja Issues related to Japanese content.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

スキルテスト: ループ の更新 :not()がおそらく不要
2 participants
@OHMORIYUSUKE @potappo