Skip to content

Conversation

@Elchi3 Elchi3 added the data:http Compat data for HTTP features. https://developer.mozilla.org/docs/Web/HTTP label Aug 7, 2019
@Elchi3 Elchi3 requested a review from ddbeck August 15, 2019 08:56
Copy link
Contributor

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for taking so long to get to this one, Florian. One set of corrections to make, but otherwise, this looks great. Thank you!

"description": "Wildcard (<code>*</code>)",
"support": {
"chrome": {
"version_added": "63"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this one didn't make it to Chrome until 65

https://storage.googleapis.com/chromium-find-releases-static/59a.html#59a2bc8acbe0926b70b5f926ae6e2383fc6dd532

I suspect some of the other browsers here need updating as a result

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woah, great catch! Astonishing how often the info on the Chrome bug tracker is just wrong.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it is funny how inconsistent it is. However, I wasn't clear here: only expose headers was in 65; the others did ship in 63.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, should have read the change set more carefully. I've set those other two back to 63.

Copy link
Contributor

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Florian! Looks great. 🎉

@ddbeck ddbeck merged commit 359f91f into master Aug 19, 2019
@Elchi3 Elchi3 deleted the cors-wildcard branch August 19, 2019 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data:http Compat data for HTTP features. https://developer.mozilla.org/docs/Web/HTTP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants