-
Notifications
You must be signed in to change notification settings - Fork 2.5k
CORS: Add data for wildcard support to certain headers #4577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ddbeck
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for taking so long to get to this one, Florian. One set of corrections to make, but otherwise, this looks great. Thank you!
| "description": "Wildcard (<code>*</code>)", | ||
| "support": { | ||
| "chrome": { | ||
| "version_added": "63" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this one didn't make it to Chrome until 65
I suspect some of the other browsers here need updating as a result
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woah, great catch! Astonishing how often the info on the Chrome bug tracker is just wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it is funny how inconsistent it is. However, I wasn't clear here: only expose headers was in 65; the others did ship in 63.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, should have read the change set more carefully. I've set those other two back to 63.
ddbeck
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Florian! Looks great. 🎉
For https://bugzilla.mozilla.org/show_bug.cgi?id=1309358#c29
These headers now accept a wildcard (
*) in certain situations:https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Access-Control-Expose-Headers
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Access-Control-Allow-Methods
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Access-Control-Allow-Headers
C.f. Fyrd/caniuse#4987