Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the add_a_loop_device test #66

Merged
merged 1 commit into from
May 20, 2023
Merged

Fixes the add_a_loop_device test #66

merged 1 commit into from
May 20, 2023

Conversation

mdaffin
Copy link
Owner

@mdaffin mdaffin commented May 20, 2023

It tried to count the existing devices by looking at the /dev/loop* files. But these may or may not be free devices so the check for an error on existing device file was failing as the count it came up with could be added. It has been changed to try adding the device twice - the first should succeed and the second should fail. This way around we garuntee the state of the first (assuming it was not added outside of the tests).

It tried to count the existing devices by looking at the /dev/loop* files. But these may or may not be free devices so the check for an error on existing device file was failing as the count it came up with could be added. It has been changed to try adding the device twice - the first should succeed and the second should fail. This way around we garuntee the state of the first (assuming it was not added outside of the tests).
@mdaffin mdaffin merged commit c9f91e8 into master May 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant