Fix creating loopdevs with read-only backing files #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for that. Will try to get a release out in the next week or so. |
|
@mdaffin Would you mind to file a release? That would be awesome and I can get rid of one more Thanks a lot! |
|
Sorry for the wait. 0.4.0 has now been released and includes these changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when a new loopdev is created with LO_FLAGS_READ_ONLY set, the backing file is still opened in RW mode. This call fails when the user does not have write-permissions on the file (for example, the file is on a read-only filesystem). This patch checks for LO_FLAGS_READ_ONLY and opens the file without write mode if the flag is set.