Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Puts direct_io support behind a feature flag #39

Merged
merged 4 commits into from
Jun 29, 2021
Merged

Puts direct_io support behind a feature flag #39

merged 4 commits into from
Jun 29, 2021

Conversation

mdaffin
Copy link
Owner

@mdaffin mdaffin commented Jun 21, 2021

For #38

flxo
flxo reviewed Jun 21, 2021
View reviewed changes
Copy link
Contributor

@flxo flxo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me beside the addition dependency test-case which is not used.

Cargo.toml Outdated Show resolved Hide resolved
@mdaffin mdaffin merged commit 0108b3c into master Jun 29, 2021
@mdaffin mdaffin deleted the direct_io-feature branch June 29, 2021 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flxo flxo flxo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdaffin @flxo