IAR compiler compatibility break in image.h #2126
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Commit needs a sign off and message text adding to commit i.e. |
Collaborator
|
@Karambite would you be able to fix this today or on Monday? Would like to pull latest changes into Zephyr with a manifest update soon |
Contributor
Author
Sorry I haven't had time to get back to this. I will try to close this over the weekend |
Contributor
Author
|
I tried to rebase and accidentally closed this PR. A new one is opened here #2149. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated image.h to avoid breaking for IAR compiler.
This is a compatibility break with the IAR compiler. __packed is already a keyword that eliminates padding between members. This is not a definition, meaning it will always fall under the #ifndef. Any additions that use __packed will be replaced by the definition given.
I created a macro that will pack the structures based on the compiler used.