Skip to content

Conversation

@KarlKTorp
Copy link
Contributor

Bootstrapping is currently not allowed for more than one image. But that seems to be unintentional according to #826 (comment)

I ran into the same issue trying to boot two images (for M7 and M4) on a i.MX RT1170 using zephyr. We solved this using the suggested change and hope it could be added to main.

With this it's possible to enable MCUmgr SMP within MCUBoot and update a device that only has the bootloader in flash.

@anedergaard anedergaard deleted the multiple_image_bootstrap branch September 20, 2024 07:14
@KarlKTorp KarlKTorp restored the multiple_image_bootstrap branch September 20, 2024 07:36
@KarlKTorp KarlKTorp changed the title Support bootstrapping for multiple images boot: Support bootstrapping for multiple images Sep 25, 2024
@KarlKTorp KarlKTorp force-pushed the multiple_image_bootstrap branch from 75abe99 to cf1343d Compare October 28, 2024 08:31
@nordicjm nordicjm requested review from d3zd3z and de-nordic October 31, 2024 07:56
@nordicjm
Copy link
Collaborator

@KarlKTorp can you fix the commit sign off?

@KarlKTorp
Copy link
Contributor Author

@KarlKTorp can you fix the commit sign off?

@nordicjm I'm not sure why it does not pass. I do have the sign-off line added. Is something else missing in the commit message?

@KarlKTorp KarlKTorp force-pushed the multiple_image_bootstrap branch from cf1343d to ba0fd6b Compare November 15, 2024 07:48
@KarlKTorp
Copy link
Contributor Author

@nordicjm I have tried to add a description line in the commit message as I can see this is common for other commits. Can we check if that solves the issue?

@KarlKTorp
Copy link
Contributor Author

KarlKTorp commented Nov 15, 2024

I have tried to change the sign-off from
Signed-off-by: Karl Kristian Dyrholm Torp <[email protected]>
to
Signed-off-by: KarlKTorp <[email protected]>
locally and running check-signed-off-by.sh. That seems to satisfy the script, but I'm not sure if that is the correct way to fix this?

@nordicjm
Copy link
Collaborator

No that is not right, follow https://docs.github.com/en/get-started/getting-started-with-git/setting-your-username-in-git to set your name correct in git then do git commit --amend --reset-author

When bootstrapping all images could have the primary slot erased

Signed-off-by: Karl Kristian Dyrholm Torp <[email protected]>
@KarlKTorp KarlKTorp force-pushed the multiple_image_bootstrap branch from ba0fd6b to cf3cba7 Compare November 15, 2024 08:38
@KarlKTorp
Copy link
Contributor Author

@nordicjm I think it should be working now. The local check was OK.

@nordicjm nordicjm merged commit eb94206 into mcu-tools:main Nov 18, 2024
58 checks passed
@KarlKTorp KarlKTorp deleted the multiple_image_bootstrap branch November 18, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants