This example from the documentation is about a completely separate issue (#31). I don't think it really needs changing at all, but we can update the timing since it has probably improved due to this and @aokellermann's optimizations.

Reviewed 2 of 2 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @daneelsan)

Kernel/setSubstitutionSystem$cpp.m, line 80 at r1 (raw file):

(* This format is used to pass both rules and set data into libSetReplace over LibraryLink *)

encodeNestedLists[l_List] := Flatten @ {Length @ l, encodeNestedLists /@ l}

Please use more descriptive variable names, e.g., l -> list and a -> arg.

Tests/performance.wlt, line 33 at r1 (raw file):

              1000]],
            List,
            TimeConstraint -> 10,

This test actually has nothing to do with this (the initial state is small here). The reason the time constraint is so large here is that the test does not fail randomly due to fluctuations in performance and would only fail if it was catastrophically slower than before.

Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @maxitg)

Kernel/setSubstitutionSystem$cpp.m, line 80 at r1 (raw file):

Done.

Tests/performance.wlt, line 33 at r1 (raw file):

Reverted the changes I made there.

Awesome! 🚀

Reviewed 2 of 2 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved