Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix WolframModelPlot for Wolfram Language 12.2 #433

Merged
merged 3 commits into from
Oct 7, 2020
Merged

Fix WolframModelPlot for Wolfram Language 12.2 #433

merged 3 commits into from
Oct 7, 2020

Conversation

maxitg
Copy link
Owner

@maxitg maxitg commented Oct 6, 2020 •
edited
Loading

Changes

  • ConvexHullMesh is broken in Wolfram Language 12.2. It seems that only 1D examples evaluate, 2D and 3D example return unevaluated even if using examples from the documentation.
  • Because of this, WolframModelPlot is currently broken.
  • This PR changes WolframModelPlot to use the new convexHullPolygon (convexHullPolygon #432) instead of ConvexHullMesh.

Comments

  • The tests will fail until convexHullPolygon #432 is merged.
  • I will also update the CI soon to version 12.2 so that the tests on the current master will start failing as well.
  • Visually verified WolframModelPlot and RulePlot on all examples from documentation.

Examples

  • WolframModelPlot now works as expected:
In[] := $Version
Out[] = "12.2.0 for Mac OS X x86 (64-bit) (October 3, 2020)"
In[] := WolframModelPlot[{{1, 2, 3}, {3, 4, 5}, {5, 6, 7}}]

image

This change is Reviewable

@maxitg maxitg added weed Something isn't working critical Critical weed that severely breaks the functionality visualization Has to do with visualization code, such as `WolframModelPlot` labels Oct 6, 2020
@maxitg maxitg merged commit b82c93e into master Oct 7, 2020
@maxitg maxitg deleted the fixWolframModelPlot branch October 7, 2020 02:37
aokellermann pushed a commit that referenced this pull request Oct 8, 2020
@maxitg @aokellermann
Fix WolframModelPlot for Wolfram Language 12.2 (#433)
211d567 
## Changes
* `ConvexHullMesh` is broken in Wolfram Language 12.2. It seems that only 1D examples evaluate, 2D and 3D example return unevaluated even if using examples from the documentation.
* Because of this, `WolframModelPlot` is currently broken.
* This PR changes `WolframModelPlot` to use the new `convexHullPolygon` (#432) instead of `ConvexHullMesh`.

## Comments
* The tests will fail until #432 is merged.
* I will also update the CI soon to version 12.2 so that the tests on the current master will start failing as well.
* Visually verified `WolframModelPlot` and `RulePlot` on all examples from documentation.

## Examples
* `WolframModelPlot` now works as expected:
```wl
In[] := $Version
Out[] = "12.2.0 for Mac OS X x86 (64-bit) (October 3, 2020)"
```
```wl
In[] := WolframModelPlot[{{1, 2, 3}, {3, 4, 5}, {5, 6, 7}}]
```
![image](https://user-images.githubusercontent.com/1479325/95257565-1e7a3800-07ea-11eb-8325-0f7e269444d2.png)

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/maxitg/setreplace/433)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taliesinb taliesinb taliesinb approved these changes

@aokellermann aokellermann Awaiting requested review from aokellermann

Assignees

@taliesinb taliesinb

Labels
critical Critical weed that severely breaks the functionality visualization Has to do with visualization code, such as `WolframModelPlot` weed Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maxitg @taliesinb @aokellermann