Skip to content

Fix reveal range #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mauricedb merged 2 commits into from
Oct 19, 2020
Merged

Fix reveal range #12

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fecff6f
Reveal the current selection instead of document end
mauricedb Oct 19, 2020
edef925
Reveal in center after goto
mauricedb Oct 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 16 additions & 6 deletions src/instruction-handlers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,12 @@
import { commands, Position, Selection, Uri, window, workspace } from 'vscode';
import {
commands,
Position,
Selection,
TextEditorRevealType,
Uri,
window,
workspace,
} from 'vscode';
import { join, dirname } from 'path';

import {
Expand Down Expand Up @@ -66,10 +74,8 @@ const typeTextIntoActiveTextEditor = async (
editBuilder.insert(editor.selection.active, char!);
if (char === '\n') {
pos = new Position(pos.line + 1, pos.character);
// scroll to last line
const lastLine = editor.document.lineCount - 1;
const lastLineRange = editor.document.lineAt(lastLine).range;
editor.revealRange(lastLineRange);
// scroll to current line if needed
editor.revealRange(editor.selection, TextEditorRevealType.Default);
} else {
pos = new Position(pos.line, pos.character + 1);
}
Expand Down Expand Up @@ -124,7 +130,11 @@ export const goto = async (instruction: GoTo): Promise<void> => {

const position = new Position(line - 1, column - 1);
editor.selection = new Selection(position, position);
editor.revealRange(editor.selection);
editor.revealRange(
editor.selection,
TextEditorRevealType.InCenterIfOutsideViewport
);

await timeout(getDelay());
};

Expand Down