Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wait #1

Merged
merged 2 commits into from
Feb 24, 2019
Merged

wait #1

merged 2 commits into from
Feb 24, 2019

Conversation

danielnoon
Copy link
Contributor

@danielnoon danielnoon commented Feb 20, 2019

Hey, there!

I needed something just like your project for a presentation, but I wanted to be able to wait a little while between instructions, so I made an instruction that adds some delay. I hope this change is helpful!

-Daniel

Copy link
Owner

@mauricedb mauricedb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Supermegadex

👍 Great feature, this was something I was already planning but you did in a better way 😄

One thing, can you remove the package-lock.json as I am using Yarn here for the dependencies?

I left a few other review items.

Thanks

src/instructions.ts Outdated Show resolved Hide resolved
src/instruction-handlers.ts Outdated Show resolved Hide resolved
@danielnoon
Copy link
Contributor Author

I made the changes you requested. Sorry I didn't get to it sooner--I didn't notice that you had made these comments because I am new to contributing and I assumed GitHub would send me a notification. Let me know if you need me to make any more changes or if you need help with something else!

-Daniel

@mauricedb mauricedb merged commit 0968aaa into mauricedb:master Feb 24, 2019
@mauricedb
Copy link
Owner

Hi @Supermegadex,

No problem, with GIT you need to watch a repository to be notified of updates.

I have merged the PR and published version 0.2.0 that should be available any minute now at https://marketplace.visualstudio.com/items?itemName=mauricedebeijer.presentation-buddy

Thanks for the PR
Maurice

mauricedb pushed a commit that referenced this pull request Mar 24, 2024
Add TypeChunksFromFile for typing file content with pauses (e.g. after each line)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants