Skip to content

MSC2966: Usage of OAuth 2.0 Dynamic Client Registration in Matrix #2966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 35 commits into from
Apr 5, 2025
Merged

MSC2966: Usage of OAuth 2.0 Dynamic Client Registration in Matrix #2966

merged 35 commits into from
Apr 5, 2025

Conversation

sandhose
Copy link
Member

@sandhose sandhose commented Jan 14, 2021 •
edited by turt2live
Loading

@turt2live turt2live changed the title MSC2966: [WIP] Usage of OAuth 2.0 Dynamic Client Registration in Matrix [WIP] MSC2966: Usage of OAuth 2.0 Dynamic Client Registration in Matrix Jan 14, 2021
@turt2live turt2live marked this pull request as draft January 14, 2021 17:28
@turt2live turt2live added kind:feature MSC for not-core and not-maintenance stuff proposal A matrix spec change proposal labels Jan 14, 2021
@sandhose sandhose mentioned this pull request Jan 15, 2021
Merged
9 tasks
richvdh
richvdh reviewed Feb 4, 2021
View reviewed changes
richvdh
richvdh reviewed Feb 13, 2021
View reviewed changes
@turt2live turt2live added the needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. label Jun 8, 2021
@sandhose sandhose mentioned this pull request Jan 17, 2022
Closed
39 tasks
@hughns hughns mentioned this pull request Aug 4, 2022
Merged
deepbluev7
deepbluev7 reviewed Feb 24, 2023
View reviewed changes
@turt2live turt2live added the matrix-2.0 Required for Matrix 2.0 label Mar 3, 2023
zecakeh
zecakeh reviewed Aug 4, 2023
View reviewed changes
This was referenced Sep 7, 2023
Closed
Closed
@sandhose sandhose mentioned this pull request Feb 7, 2024
Open
@sandhose sandhose closed this Sep 3, 2024
@sandhose sandhose deleted the msc/sandhose/oauth2-dynamic-registration branch September 3, 2024 10:23
@sandhose sandhose restored the msc/sandhose/oauth2-dynamic-registration branch September 3, 2024 10:24
@sandhose sandhose reopened this Sep 3, 2024
@sandhose sandhose changed the base branch from old_master to main September 3, 2024 10:25
@matrixbot matrixbot mentioned this pull request Sep 9, 2024
Closed
39 tasks
@sandhose
Rework MSC
32c9ead 
 - makes some metadata optional
 - better explain how each metadata field is used
 - better explain what the restrictions on redirect_uris are
 - remove the signed metadata part
 - mention the client metadata JSON document alternative
@sandhose sandhose changed the title [WIP] MSC2966: Usage of OAuth 2.0 Dynamic Client Registration in Matrix MSC2966: Usage of OAuth 2.0 Dynamic Client Registration in Matrix Sep 13, 2024
@sandhose sandhose marked this pull request as ready for review September 13, 2024 15:41
clokep
clokep reviewed Mar 25, 2025
View reviewed changes
@richvdh
Copy link
Member

richvdh commented Mar 25, 2025

@mscbot concern no way for servers to gc old client IDs

erikjohnston
erikjohnston reviewed Mar 26, 2025
View reviewed changes
@erikjohnston
Copy link
Member

@mscbot resolve we should be able to delete unused client registrations

@erikjohnston

This comment was marked as duplicate.

Sign in to view
@erikjohnston
Copy link
Member

@mscbot resolve no way for servers to gc old client IDs

@mscbot mscbot removed the unresolved-concerns This proposal has at least one outstanding concern label Mar 26, 2025
dbkr
dbkr reviewed Mar 31, 2025
View reviewed changes
proposals/2966-oauth2-dynamic-registration.md

This proposal is part of the broader [MSC3861: Next-generation auth for Matrix, based on OAuth 2.0/OIDC][MSC3861].

This MSC specifies how Matrix clients SHOULD leverage the OAuth 2.0 Dynamic Client Registration Protocol ([RFC 7591](https://tools.ietf.org/html/rfc7591)) to register themselves before initiating an authorization flow.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not to be a stickler, but I think having this 'should' in formal capitals technically implies the whole MSC is optional, which is probably not what you want.

@mscbot
Copy link
Collaborator

mscbot commented Mar 31, 2025

🔔 This is now entering its final comment period, as per the review above. 🔔

@mscbot mscbot added final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. and removed proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. labels Mar 31, 2025
@turt2live turt2live moved this from Ready for FCP ticks to In FCP in Spec Core Team Backlog Mar 31, 2025
@zecakeh zecakeh mentioned this pull request Apr 2, 2025
Merged
@mscbot
Copy link
Collaborator

mscbot commented Apr 5, 2025

The final comment period, with a disposition to merge, as per the review above, is now complete.

@mscbot mscbot added finished-final-comment-period and removed disposition-merge final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. labels Apr 5, 2025
@turt2live turt2live merged commit d83a46e into matrix-org:main Apr 5, 2025
1 check failed
@turt2live turt2live moved this from In FCP to Requires spec writing in Spec Core Team Backlog Apr 5, 2025
@turt2live turt2live added spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec and removed finished-final-comment-period labels Apr 5, 2025
@NinekoTheCat NinekoTheCat mentioned this pull request Apr 18, 2025
Open
@zecakeh
Copy link
Contributor

zecakeh commented May 24, 2025

spec PR: matrix-org/matrix-spec#2148

@tulir tulir added spec-pr-in-review A proposal which has been PR'd against the spec and is in review and removed spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec labels May 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richvdh richvdh richvdh left review comments

@dbkr dbkr dbkr left review comments

@ara4n ara4n ara4n left review comments

@MTRNord MTRNord MTRNord left review comments

@clokep clokep clokep left review comments

@t3chguy t3chguy t3chguy left review comments

@tulir tulir tulir left review comments

@tonkku107 tonkku107 tonkku107 left review comments

@erikjohnston erikjohnston erikjohnston left review comments

@deepbluev7 deepbluev7 deepbluev7 left review comments

@zecakeh zecakeh zecakeh left review comments

@turt2live turt2live turt2live approved these changes

@anoadragon453 anoadragon453 anoadragon453 approved these changes

Assignees
No one assigned
Labels
kind:core MSC which is critical to the protocol's success matrix-2.0 Required for Matrix 2.0 proposal A matrix spec change proposal spec-pr-in-review A proposal which has been PR'd against the spec and is in review
Projects
Spec Core Team Backlog
Status: Requires spec writing
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.