Skip to content

Make metrics less error prone #810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Half-Shot wants to merge 4 commits into from
Closed

Make metrics less error prone #810

Half-Shot wants to merge 4 commits into from

Conversation

@Half-Shot
Copy link
Contributor

@Half-Shot Half-Shot commented Jul 13, 2022

The bridge is prone to erroring with things like:

(node:1) UnhandledPromiseRejectionWarning: TypeError: Cannot read property 'get' of undefined
    at PrometheusBridgeMetrics.sdkEndMetric (/src/metrics.ts:207:54)
    at /node_modules/matrix-bot-sdk/lib/metrics/Metrics.js:73:39
    at Array.forEach (<anonymous>)
    at Metrics.end (/node_modules/matrix-bot-sdk/lib/metrics/Metrics.js:73:24)
    at /node_modules/matrix-bot-sdk/lib/metrics/decorators.js:35:40
    at <anonymous>
    at processTicksAndRejections (internal/process/task_queues.js:95:5)

Which is mostly due to the fact that our metrics system is:

  1. Not correctly initalising the Maps
  2. Listening in the wrong places for the wrong metrics.

I've also updated the matrix-appservice-bridge library to be on the latest version, I don't think it's changes will affect us too badly.

@Half-Shot
Copy link
Contributor Author

Half-Shot commented Jul 15, 2022

Depends on #811 due to requiring Node 14.

@Half-Shot Half-Shot requested a review from a team July 15, 2022 08:21
AndrewFerr
AndrewFerr requested changes Jul 15, 2022
View reviewed changes
src/discordas.ts
@@ -1,5 +1,5 @@
/*
Copyright 2017 - 2019 matrix-appservice-discord
Copyright 2017 - 2019 matrix-appservice-discord, 2022 (C) The Matrix.org Foundation C.I.C.
Copy link
Member

@AndrewFerr AndrewFerr Jul 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe let's just make a single change to update all of these at once 😆

src/discordas.ts
const eventProcessor = discordbot.MxEventProcessor;


process.once("SIGINT", () => {
Copy link
Member

@AndrewFerr AndrewFerr Jul 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should trigger on SIGTERM too.

src/bot.ts
public stop(): void {
this.presenceHandler.Stop();
this._bot?.destroy();
this._bot = undefined;
Copy link
Member

@AndrewFerr AndrewFerr Jul 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick suggestion:

if (this._bot) {
    this._bot.destroy();
    this._bot = undefined; 
}

since there's a branch buried in the ?. anyways.

@Half-Shot Half-Shot self-assigned this Aug 11, 2022
@Half-Shot
Copy link
Contributor Author

Half-Shot commented Dec 29, 2025

Hey there people on the tail end of 2025, closing this PR just due to lack of time to continue to work on this project personally. It will be up to the matrix-org fdn to find someone to pick this up, if it's still useful.

@Half-Shot Half-Shot closed this Dec 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndrewFerr AndrewFerr AndrewFerr requested changes

Assignees

@Half-Shot Half-Shot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Half-Shot @AndrewFerr