Skip to content

FIX: remove __array__ method on BasicUnit #28744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
tacaswell wants to merge 3 commits into
base: main
Choose a base branch
from
Open

FIX: remove __array__ method on BasicUnit #28744

tacaswell wants to merge 3 commits into from

Conversation

@tacaswell
Copy link
Member

@tacaswell tacaswell commented Aug 21, 2024

The presence of this method causes the numpy float mul to use it in numpy 2.1 which results in the units not being tagged as expected and the example failing.

PR summary

PR checklist

@tacaswell
FIX: remove __array__ method on BasicUnit
2b3d142 
The presence of this method causes the numpy float __mul__ to use it
in numpy 2.1 which results in the units not being tagged as expected and
the example failing.
@tacaswell tacaswell added this to the v3.9-doc milestone Aug 21, 2024
@github-actions github-actions bot added the Documentation: examples files in galleries/examples label Aug 21, 2024
@tacaswell
Copy link
Member Author

tacaswell commented Aug 21, 2024

Sorry, I did this a while ago but forgot to actually open the PR!

QuLogic
QuLogic requested changes Aug 21, 2024
View reviewed changes
Copy link
Member

@QuLogic QuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks the docs with NumPy 2.0.1.

@QuLogic
Copy link
Member

QuLogic commented Aug 21, 2024 •
edited
Loading

So the bisect points this to numpy/numpy@682cd04 via numpy/numpy#26904.

Reading through the array API docs, it seems like setting __array_priority__ higher (default is 0) may also work, in order to ensure that our __array_wrap__ method is called regardless of version, and we don't end up with a bare array. Alternatively, we could implement __array_ufunc and/or __array_function__.

@scottshambaugh scottshambaugh mentioned this pull request Aug 31, 2024
Merged
5 tasks
@timhoffm timhoffm modified the milestones: v3.9-doc, v3.10.0-doc Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@QuLogic QuLogic QuLogic requested changes

@timhoffm timhoffm timhoffm approved these changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

Documentation: examples files in galleries/examples status: needs rebase topic: units and array ducktypes

Projects

None yet

Milestone

v3.10-doc

Development

Successfully merging this pull request may close these issues.

5 participants

@tacaswell @QuLogic @timhoffm @dstansby @ksunden