[MNT] swap xkcd script for humor sans #27299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
story645
force-pushed
the
remove-humorsans
branch
from
4e4114e to
1d790e4
Compare
tacaswell
approved these changes
Nov 9, 2023
Member
Author
|
attn @ksunden why xkcd script>xkcd |
oscargus
reviewed
Nov 10, 2023
oscargus
reviewed
Nov 10, 2023
story645
force-pushed
the
remove-humorsans
branch
5 times, most recently
from
ed0b8d3 to
b54fed4
Compare
QuLogic
reviewed
Nov 15, 2023
| For best results, the "Humor Sans" font should be installed: it is | ||
| not included with Matplotlib. | ||
| For best results, install the `xkcd script <https://github.com/ipython/xkcd-font/>`_ |
Member
There was a problem hiding this comment.
This doesn't seem to be the same link as what is used for CI, and the dependencies page.
Member
Author
There was a problem hiding this comment.
I think what I should probably do is see if the plain xkcd script works & if so use that and if not PR the xkcd branch (haven't heard back from author)
story645
force-pushed
the
remove-humorsans
branch
from
b54fed4 to
3215acb
Compare
QuLogic
reviewed
Nov 15, 2023
Member
Author
|
So for this PR I can get away w/ the xkcd-font on ipython since no negative ticks, but I need to fix this PR cause it's not using that font right now |
story645
force-pushed
the
remove-humorsans
branch
3 times, most recently
from
e8b9dea to
be9c90d
Compare
add xkcd-script font to doc build Co-authored-by: Oscar Gustafsson <[email protected]>
story645
force-pushed
the
remove-humorsans
branch
from
be9c90d to
0c34e5e
Compare
Member
Author
|
Ok, so docs now build w/ xckd-script font |
ksunden
approved these changes
Nov 17, 2023
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Nov 17, 2023
QuLogic
added a commit
that referenced
this pull request
Nov 17, 2023
…299-on-v3.8.x Backport PR #27299 on branch v3.8.x ([MNT] swap xkcd script for humor sans)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This swaps xkcd-script for the Humor sans font b/c the way Humor sans handles the .notdef character is leading to dropped - without warning #27232
This is cherry picked out of #26854
I think we should fork a copy of the xkcd branch under matplotlib because I'm uncomfortable with relying on an unmaintained fork of an unmaintained project, but this is the most complete character set.
PR summary
PR checklist