Make it possible to detect other clients than Browsers #16197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsteur
reviewed
Jul 10, 2020
tsteur
reviewed
Jul 10, 2020
sgiehl
commented
Jul 13, 2020
mattab
added
the
Enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prepares Matomo for better reports on used clients. Currently Matomo shows all clients that are not detected as a browser as
Unknown. With this changes the column that currently stores the browser short code will be increased in size, to be able to store full client names. Additionally there will be a new column to store the client type (represented with an int id).Besides changing the database I've also decided to already store the full name for clients (other than browsers). That way those other clients will already appear in the "Browsers" reports. That might not be fully correct, but imho better than report them as unknown. The client type will also be set already, but should be invisible everywhere (except from custom reports maybe)
Note: It's currently not possible to segment for those other clients, as the browser segment still only accepts the short codes. That's something we can add later, when we possibly also add new reports for each client type or so.
refs #5413