Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare new major release 4.0 #6014

Closed
wants to merge 15 commits into from
Closed

Prepare new major release 4.0 #6014

wants to merge 15 commits into from

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Aug 18, 2019 •
edited
Loading

  • increase requirement to PHP 7.1
  • use strict types
  • improve code quality using phpstan and phpcs
  • removes browser & os short codes

@Findus23
Copy link
Member

Findus23 commented Aug 20, 2019 •
edited
Loading

@sgiehl What's the plan for removing short code in Matomo?
While this makes things easier and renaming the icons should be pretty easy, I wonder if this might cause new issues in the future.
What if in the future an OS or Browser gets renamed (which doesn't seem that unlikely)?

@sgiehl
Copy link
Member Author

sgiehl commented Aug 20, 2019

@Findus23 that needs to be handled with matomo-org/matomo#5413
And I would ignore the case if a browser get's renamed. But we could maybe maintain a list of "alias names" in device detector and group the records in matomo with this info

Alternatively if the client detection won't make it into Matomo soon, we need to maintain the shortcode list there.

@sgiehl sgiehl force-pushed the v4 branch 5 times, most recently from b965528 to 44e7ae3 Compare September 2, 2019 09:16
@sgiehl sgiehl force-pushed the v4 branch 4 times, most recently from 65c9c99 to 0f08fdd Compare September 27, 2019 14:46
@sgiehl sgiehl force-pushed the v4 branch 2 times, most recently from 7788806 to 6093675 Compare October 28, 2019 12:57
@sgiehl sgiehl mentioned this pull request Jan 7, 2020
Closed
@sgiehl sgiehl force-pushed the v4 branch 6 times, most recently from 4c9f4ff to c8c9add Compare January 13, 2020 16:00
@sgiehl sgiehl linked an issue Aug 18, 2020 that may be closed by this pull request
Unify empty responses #5951
Closed
@sgiehl
Copy link
Member Author

sgiehl commented Oct 30, 2020

Closing as most parts of it were included in another PR

@sgiehl sgiehl closed this Oct 30, 2020
@sgiehl sgiehl deleted the v4 branch July 19, 2021 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unify empty responses
3 participants
@sgiehl @Findus23 @mimmi20