Skip to content

update twemojie to v2 #7911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 5, 2018
Merged

update twemojie to v2 #7911

merged 1 commit into from
Jul 5, 2018

Conversation

Dryusdan
Copy link
Contributor

Twemojie add v2 and add some emojie. I push new twemojie

@Gargron
Copy link
Member

Gargron commented Jun 29, 2018

It's very difficult for me to review 2,841 changed files. Could you write down what you did so I can reproduce it? Is it the v11 release? https://github.com/twitter/twemoji/releases/tag/v11.0.0

@Dryusdan
Copy link
Contributor Author

Hum, okay.

I clone https://github.com/twitter/twemoji, I going on twemojie/2/svg and I copy all svg file to mastodon's public/emoji folder :)

That all. (and it work on my instance)

Copy link
Member

@Gargron Gargron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I followed the steps and arrived at the identical result, so if the twemoji repository is not compromised, this patch is clean.

@Gargron Gargron merged commit 17b9285 into mastodon:master Jul 5, 2018
@trwnh
Copy link
Member

trwnh commented Jul 6, 2018

The file number seems high because there are a lot of SVGs being updated -- at minimum, for each SVG, metadata has been removed and paths have been simplified.

lawremipsum pushed a commit to lawremipsum/mspsocial-mastodon that referenced this pull request Jul 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants