-
-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dependencies for uWebSockets #7466
Conversation
UWS needs openssl and zlib https://github.com/uNetworking/uWebSockets/wiki/Misc.-details#dependencies
cc @zunda |
Unfortunately, this change didn't solve the problem. Does anybody happen to know what are still missing?
With little time to spare to look into this, I've been resorting to use older version of npm. |
Hmm, what version of Node.js is heroku running? |
That's why it fails to compile This PR brings node 10 support to uws #7448 edit: and drops node 6 support as noted below. |
We have a small problem. That PR removes Node.js 6 support. I think if people will be forced to move from Node.js 6 because of the 2.4 release, they will be very frustrated. But if this is absolutely necessary, we'll have no choice. |
Had to update standalone my stand alone install too. All i had to do was curl -sL https://deb.nodesource.com/setup_8.x | bash then... done |
- Set Heroku stack in app.json - Revert mastodon#7466 removing libssl-dev and zlib1g-dev: libssl-dev is known to crash Puma when built on Heroku-18 stack
UWS needs openssl and zlib. FYI: https://github.com/uNetworking/uWebSockets/wiki/Misc.-details#dependencies