Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependencies for uWebSockets #7466

Merged
merged 1 commit into from
Jul 13, 2018
Merged

Add dependencies for uWebSockets #7466

merged 1 commit into from
Jul 13, 2018

Conversation

tribela
Copy link
Contributor

@tribela tribela commented May 13, 2018

@ykzts
Copy link
Member

ykzts commented May 13, 2018

cc @zunda

@zunda
Copy link
Contributor

zunda commented May 14, 2018

Unfortunately, this change didn't solve the problem. Does anybody happen to know what are still missing?

$ heroku stack -a zundan-mastodon-staging-pr-6 | grep \*
* heroku-16
$ heroku run bash -a zundan-mastodon-staging-pr-6
~ $ npm start

> mastodon@ start /app
> node ./streaming/index.js

/app/node_modules/uws/uws.js:38
            throw new Error('Compilation of µWebSockets has failed and there is no pre-compiled binary ' +
            ^

Error: Compilation of µWebSockets has failed and there is no pre-compiled binary available for your system. Please install a supported C++11 compiler and reinstall the module 'uws'.
    at native (/app/node_modules/uws/uws.js:38:19)
    at Object.<anonymous> (/app/node_modules/uws/uws.js:42:3)
    at Module._compile (internal/modules/cjs/loader.js:678:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:689:10)
    at Module.load (internal/modules/cjs/loader.js:589:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:528:12)
    at Function.Module._load (internal/modules/cjs/loader.js:520:3)
    at Module.require (internal/modules/cjs/loader.js:626:17)
    at require (internal/modules/cjs/helpers.js:20:18)
    at Object.<anonymous> (/app/streaming/index.js:10:19)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! mastodon@ start: `node ./streaming/index.js`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the mastodon@ start script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /app/.npm/_logs/2018-05-14T19_57_28_066Z-debug.log
~ $ cat /app/.npm/_logs/2018-05-14T19_57_28_066Z-debug.log
0 info it worked if it ends with ok
1 verbose cli [ '/app/.heroku/node/bin/node',
1 verbose cli   '/app/.heroku/node/bin/npm',
1 verbose cli   'start' ]
2 info using [email protected]
3 info using [email protected]
4 verbose config Skipping project config: /app/.npmrc. (matches userconfig)
5 verbose run-script [ 'prestart', 'start', 'poststart' ]
6 info lifecycle mastodon@~prestart: mastodon@
7 info lifecycle mastodon@~start: mastodon@
8 verbose lifecycle mastodon@~start: unsafe-perm in lifecycle true
9 verbose lifecycle mastodon@~start: PATH: /app/.heroku/node/lib/node_modules/npm/node_modules/npm-lifecycle/node-gyp-bin:/app/node_modules/.bin:/app/bin:/app/vendor/bundle/bin:/app/vendor/bundle/ruby/2.5.0/bin:/app/.heroku/node/bin:/app/.heroku/yarn/bin:/app/.apt/usr/bin:/usr/local/bin:/usr/bin:/bin:/app/bin:/app/node_modules/.bin
10 verbose lifecycle mastodon@~start: CWD: /app
11 silly lifecycle mastodon@~start: Args: [ '-c', 'node ./streaming/index.js' ]
12 silly lifecycle mastodon@~start: Returned: code: 1  signal: null
13 info lifecycle mastodon@~start: Failed to exec start script
14 verbose stack Error: mastodon@ start: `node ./streaming/index.js`
14 verbose stack Exit status 1
14 verbose stack     at EventEmitter.<anonymous> (/app/.heroku/node/lib/node_modules/npm/node_modules/npm-lifecycle/index.js:285:16)
14 verbose stack     at EventEmitter.emit (events.js:182:13)
14 verbose stack     at ChildProcess.<anonymous> (/app/.heroku/node/lib/node_modules/npm/node_modules/npm-lifecycle/lib/spawn.js:55:14)
14 verbose stack     at ChildProcess.emit (events.js:182:13)
14 verbose stack     at maybeClose (internal/child_process.js:957:16)
14 verbose stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:246:5)
15 verbose pkgid mastodon@
16 verbose cwd /app
17 verbose Linux 4.4.0-1014-aws
18 verbose argv "/app/.heroku/node/bin/node" "/app/.heroku/node/bin/npm" "start"
19 verbose node v10.1.0
20 verbose npm  v5.6.0
21 error code ELIFECYCLE
22 error errno 1
23 error mastodon@ start: `node ./streaming/index.js`
23 error Exit status 1
24 error Failed at the mastodon@ start script.
24 error This is probably not a problem with npm. There is likely additional logging output above.
25 verbose exit [ 1, true ]
~ $ cat Aptfile 
ffmpeg
libicu[0-9][0-9]
libicu-dev
libidn11
libidn11-dev
libpq-dev
libprotobuf-dev
libssl-dev
libxdamage1
libxfixes3
protobuf-compiler
zlib1g-dev

With little time to spare to look into this, I've been resorting to use older version of npm.

@ignisf
Copy link
Contributor

ignisf commented May 15, 2018

Hmm, what version of Node.js is heroku running?

@ignisf
Copy link
Contributor

ignisf commented May 15, 2018

3 info using [email protected]

That's why it fails to compile

This PR brings node 10 support to uws #7448

edit: and drops node 6 support as noted below.

@Gargron
Copy link
Member

Gargron commented May 15, 2018

This PR brings node 10 support to uws #7448

We have a small problem. That PR removes Node.js 6 support. I think if people will be forced to move from Node.js 6 because of the 2.4 release, they will be very frustrated. But if this is absolutely necessary, we'll have no choice.

@Gargron Gargron added the deployment Related to runtime configuration, production setups label Jun 15, 2018
@Gargron Gargron merged commit c8c25ea into mastodon:master Jul 13, 2018
@jebuskrust
Copy link

jebuskrust commented Jul 14, 2018

Had to update standalone my stand alone install too.

All i had to do was curl -sL https://deb.nodesource.com/setup_8.x | bash then... done

zunda added a commit to zunda/mastodon that referenced this pull request Aug 5, 2018
- Set Heroku stack in app.json
- Revert mastodon#7466 removing libssl-dev and zlib1g-dev:
  libssl-dev is known to crash Puma when built on Heroku-18 stack
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployment Related to runtime configuration, production setups
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants