Auth sign out #2511
Merged
Auth sign out #2511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjankowski
force-pushed
the
auth-sign-out
branch
6 times, most recently
from
dcebb0b to
7aaf7f6
Compare
|
Do we want to make suspended users signing out easier? Signing out means they get to see/use the sign up page again. It's not hard to reset your cookies to get the same result, but I feel like maybe we shouldn't make it easier? |
|
You could have a shared public computer with a suspended user and the cookies wind up in a state where that browser cannot access that instance until cookies are reset or expire, which maybe not everyone knows how to do? I see your point re: not wanting to make it easier for someone in an abuse/spam cycle to create new accounts more easily, though... |
mjankowski
force-pushed
the
auth-sign-out
branch
7 times, most recently
from
3ad671e to
66eeffe
Compare
Gargron
approved these changes
May 2, 2017
ClearlyClaire
added a commit
to ClearlyClaire/mastodon
that referenced
this pull request
Dec 10, 2023
Further reduce code differences with upstream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2491