Red favicon for dev #2470
Merged
Red favicon for dev #2470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike-burns
reviewed
Apr 26, 2017
| @@ -5,6 +5,7 @@ | |||
| %meta{:name => 'viewport', :content => 'width=device-width, initial-scale=1'}/ | |||
| %meta{'http-equiv' => 'X-UA-Compatible', :content => 'IE=edge'}/ | |||
|
|
|||
| %link{:rel => "icon", :href => "#{favicon_path}", :type => "image/x-icon"}/ | |||
There was a problem hiding this comment.
The quotes and interpolation around the helper method are optional/redundant here.
%link{:rel => "icon", :href => favicon_path, :type => "image/x-icon"}/
There was a problem hiding this comment.
Whoops! Updated. (I feel like it's been so long since I've used haml I overthought it)
Gargron
approved these changes
Apr 26, 2017
seefood
pushed a commit
to Toootim/mastodon
that referenced
this pull request
Apr 28, 2017
* Set a dev specific favicon * Consistent spacing * Add trailing slash for consistency * Update to remove interpolation
ClearlyClaire
added a commit
to ClearlyClaire/mastodon
that referenced
this pull request
Nov 16, 2023
Clean up some more and reduce unwarranted differences with upstream further
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is super low priority but I found it helpful in my own work so I don't confuse local dev and production environments to have a red favicon on the dev environment. It's something that I have found super helpful, though my feelings won't be hurt if you decide not to merge. 😄