Update retention model sql query #24249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Rails 7 the arguments for `select_all` changed how the "binds" are prepared. This change updates the method to use a more clear sql preparation and sanitization approach and calls the query more simply.
Gargron
approved these changes
Mar 25, 2023
neatchee
pushed a commit
to neatchee/mastodon
that referenced
this pull request
Mar 27, 2023
neatchee
pushed a commit
to neatchee/mastodon
that referenced
this pull request
Mar 28, 2023
arachnist
pushed a commit
to arachnist/mastodon
that referenced
this pull request
Apr 4, 2023
skerit
pushed a commit
to 11ways/mastodon
that referenced
this pull request
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Rails 7 the arguments for
select_allchanged how the "binds" are prepared. This change updates the method to use a more clear sql preparation and sanitization approach and calls the query more simply.As far as I can tell the generated SQL query and the resulting cohort object produced stay the same with this change.
(Extracted in advance from #24241)