Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up the post deployment migration generator #24233

Merged

Conversation

mjankowski
Copy link
Contributor

Collection of changes around this generator:

  • Update the generator itself to use the built-in activerecord timestamp calculator, instead of it's own method.
  • Add spec coverage asserting things about the generator output.
  • Change the template filename to end in .erb
  • Change the template to use the current migration version, instead of hard coding 5.2.
  • Add a USAGE file which will be output when generator run with no args.

@mjankowski mjankowski force-pushed the migration-generator-refactor branch 2 times, most recently from 704e893 to 0e4a0f8 Compare March 27, 2023 13:50
Collection of changes around this generator:

- Update the generator itself to use the built-in activerecord
  timestamp calculator, instead of it's own method.
- Add spec coverage asserting things about the generator output.
- Change the template filename to end in `.erb`
- Change the template to use the current migration version, instead of
  hard coding `5.2`.
- Add a USAGE file which will be output when generator run with no args.
@mjankowski mjankowski force-pushed the migration-generator-refactor branch from 0e4a0f8 to 9103d60 Compare March 27, 2023 18:11
@ClearlyClaire ClearlyClaire merged commit a2a6630 into mastodon:main Apr 11, 2023
skerit pushed a commit to 11ways/mastodon that referenced this pull request Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants