Remove instance variables from helper usage #24203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjankowski
force-pushed
the
helper-instance-vars
branch
2 times, most recently
from
b9e9a66 to
6d051dc
Compare
mjankowski
force-pushed
the
helper-instance-vars
branch
from
6d051dc to
371da16
Compare
mjankowski
force-pushed
the
helper-instance-vars
branch
from
371da16 to
7281d1a
Compare
Gargron
approved these changes
Apr 23, 2023
michealmikeyb
pushed a commit
to michealmikeyb/mastodon
that referenced
this pull request
May 3, 2023
skerit
pushed a commit
to 11ways/mastodon
that referenced
this pull request
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were 3 helpers violating the
Rails/HelperInstanceVariablecop. In each chase there was an i-var set outside the context of the helper which the method was assuming would be set, instead of getting explicitly passed in.This updates those three places to pass in the needed value instead of assuming the i-var exists.